1363463 - Should only have one dtd key for the "Learn more" string

Status: NEW

(Firefox :: Settings UI, enhancement)

Description

[Evan Tseng [:evanxd]]

Should only have one key for the "Learn more" string. Currently, we have multiple keys for the "Learn more" string. For example, [1][2][3]. We should only have one, see also at https://bugzilla.mozilla.org/show_bug.cgi?id=1360140#c8.

[1]: http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/advanced.dtd#34
[2]: http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/advanced.dtd#39
[3]: http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/advanced.dtd#44

Comment 1

[Francesco Lodolo [:flod]]

There's a reason for this, and that's avoiding that a developer comes in, finds a "Learn More" string, and decides to use it in a completely different context.

If we can make sure that doesn't happen, for example adding a very clear localization comment explaining that such string should be only used following a label in preferences, in form of an hyperlink link, I'm fine with having only one string ID.