1360140 - Add Learn More link for the "Use recommended performance settings" checkbox

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Evan Tseng [:evanxd]]

Add Learn More link for the "Use recommended performance settings" checkbox. The design spec is [1].

[1]: https://mozilla.invisionapp.com/share/C2B97CAYH#/screens/230367023

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1360140 - Add Learn More link for the Use recommended performance settings checkbox

Review commit: https://reviewboard.mozilla.org/r/136200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136200/

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8864519 [details]
Bug 1360140 - Add Learn More link for the Use recommended performance settings checkbox

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136200/diff/1-2/

Comment 3

[Evan Tseng [:evanxd]]

Received an email from Joni Savage. The URL is `https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/performance`. But now the content is empty. She will work on that on Bug 1359735.

Comment 4

[Evan Tseng [:evanxd]]

Mike's review queue maxed out, and Jared is on PTO. We might need to wait for some time and continue to review the patch.

Comment 5

[Evan Tseng [:evanxd]]

Pushed the try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=93467c8a82b3

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8864519 [details]
Bug 1360140 - Add Learn More link for the Use recommended performance settings checkbox

https://reviewboard.mozilla.org/r/136200/#review140374

Feels kind of strange to have the same "Learn more" duplicated in multiple places, and having different keys. Oh well.

::: browser/locales/en-US/chrome/browser/preferences/advanced.dtd:136
(Diff revision 2)
>  <!ENTITY useRecommendedPerformanceSettings.description
>                                           "Recommended performance settings are tailored to your computer.">
>  <!ENTITY useRecommendedPerformanceSettings.accesskey
>                                           "U">
> +<!ENTITY performanceSettingsLearnMore.label
> +                                         "Learn More">

The design spec has the "M" in "More" lowercased.

Comment 7

[Evan Tseng [:evanxd]]

Comment on attachment 8864519 [details]
Bug 1360140 - Add Learn More link for the Use recommended performance settings checkbox

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136200/diff/2-3/

Comment 8

[Evan Tseng [:evanxd]]

(In reply to Mike Conley (:mconley) - At work week, slow to respond from comment #6)
> Comment on attachment 8864519 [details]
> Bug 1360140 - Add Learn More link for the Use recommended performance
> settings checkbox
> 
> https://reviewboard.mozilla.org/r/136200/#review140374
> 
> Feels kind of strange to have the same "Learn more" duplicated in multiple
> places, and having different keys. Oh well.

I agree, that is kind of strnage. I think we only should have one key for "Learn more" string. How about we file a follow up bug to address that?

Comment 9

[Evan Tseng [:evanxd]]

Let's land the patch after the treeherder task[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0019ac0ecef8

Comment 10

[Evan Tseng [:evanxd]]

And thanks Mike for reviewing.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

(In reply to Evan Tseng [:evanxd] from comment #8)
> I agree, that is kind of strnage. I think we only should have one key for
> "Learn more" string. How about we file a follow up bug to address that?

Sounds good.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e122fba32bf8
Add Learn More link for the Use recommended performance settings checkbox r=mconley

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e122fba32bf8

Comment 14

[Azmina]

Learn More link for the "Use recommended performance settings" checkbox has been implemented with Latest Nightly 55.0a1 on Windows 8.1 (64 bit).

Build ID :  20170608030205
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]

Comment 15

[Md Maruf Rahman]

This bug was about adding Learn More link for the "Use recommended performance settings" checkbox and I have seen the feature being implemented with latest Nightly on Ubuntu 16.04 LTS!

Build ID   :  20170613100218
User Agent :  Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 16

[Azmina]

As per comment 14 & comment 15, I am making this bug's status as verified fixed!