406787 - Empty index shown after ftp error if you hit return in the URL Bar

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Not interested in Mozilla any more]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

If you go to a secure website and happen to get your username or password wrong Firebox still caches those credentials for future loads of that page. Until recently the only way to clear that cache was to quit Firefox and restart it. Even now you have to select Tools/Clear private data then clear a load of check boxes and press enter. Pretty cruel punishment for simply getting your password wrong.

Firefox should not be caching the username and password if you fail to login correctly. Reloading the page should ask again for the username and password.

Reproducible: Always

Steps to Reproduce:
1. Go to a secure website.
2. Enter your username and get the password wrong.

An error 401 is generated by the server.

3. Attempt to reload the page to have another go at entering your password.
Actual Results:  
The same error 401 is returned.

Expected Results:  
The username and password should be requested again.

Comment 1

[u554791]

Happens on error 530 too. Firefox 3, all versions.

Comment 2

[Matthias Versen [:Matti]]

This is wfm with Mozilla/5.0 (Windows; U; Windows NT 6.0; rv:1.9b3pre) Gecko/2007122503 SeaMonkey/2.0a1pre and FF3.0b1 using http://matti.no-ip.org/admin and entering wrong login.

Comment 3

[Not interested in Mozilla any more]

(In reply to comment #2)
> This is wfm with Mozilla/5.0 (Windows; U; Windows NT 6.0; rv:1.9b3pre)
> Gecko/2007122503 SeaMonkey/2.0a1pre and FF3.0b1 using
> http://matti.no-ip.org/admin and entering wrong login.
> 

Agreed it does seem to work in 3.0 beta 2, but not in any version 2 or previous

Comment 4

[u554791]

(In reply to comment #2)
> This is wfm with Mozilla/5.0 (Windows; U; Windows NT 6.0; rv:1.9b3pre)
> Gecko/2007122503 SeaMonkey/2.0a1pre and FF3.0b1 using
> http://matti.no-ip.org/admin and entering wrong login.
> 

I cannot get it to work. Did you try on a ftp connection? (you can try on ftp://adys.stools.net/)

Comment 5

[Matthias Versen [:Matti]]

Please don't add the reply because it makes bug reports longer and worse readable.

For the first thing, ftp and http are absolut different things.
I found only one very minor problem with ftp that I get an empty index if I hit return in the URL bar (for reloading) but i get a new prompt if I hit reload or shift+reload.
This could be caused by teh fast forward/backward cache.

Do you mean that minor problem ?

Comment 6

[u554791]

It also happens if you try to enter the URL again (or just press enter). Using reload indeed prompts me again.

Comment 7

[Matthias Versen [:Matti]]

I can reproduce this with FTP and the ftp URl from comment #4

1) Open Tab with the FTP URL
2) hit cancel
3) put the cursor in the URL Bar and hit enter
4) you get an empty index

Comment 10

[Michal Novotny [:michal]]

Attachment: destroy cache entry if it doesn't contain valid directory listing [Checkin: Comment 12]

This bug is similar to #122548. nsICacheSession::OpenCacheEntry() creates new empty cache entry if it doesn't exists. When whatever fails during FTP communication the valid empty entry stays in the cache. This patch changes the behaviour so that cache entry is deleted by default when it is released. It is not deleted if

- valid directory listing was obtained
- cache was used to read the data

Patch from bug #122548 is no longer necessary but I kept it because it make sense to doom and release cache entry before it is filled by the file content.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 326454 [details] [diff] [review]
destroy cache entry if it doesn't contain valid directory listing
[Checkin: Comment 12]

r+sr=bzbarsky.  Silly mutating bugs!

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 326454 [details] [diff] [review]
destroy cache entry if it doesn't contain valid directory listing
[Checkin: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/e53451896ad3

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 326454 [details] [diff] [review]
destroy cache entry if it doesn't contain valid directory listing
[Checkin: Comment 12]

Too late for 1.9.0.5 but we can look at for next time.

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 326454 [details] [diff] [review]
destroy cache entry if it doesn't contain valid directory listing
[Checkin: Comment 12]

Approved for 1.9.0.6, a=dveditz for release-drivers.

Comment 16

[Daniel Veditz [:dveditz]]

Checked into 1.9.0 branch

Comment 17

[Al Billings [:abillings - ex-MoCo]]

Verified fixed for 1.9.0.6 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.6pre) Gecko/2009011304 GranParadiso/3.0.6pre.