248688 - Thunderbird biff integration refers to the old profile APIs

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

When starting up the app, nsMessengerWinIntegration trys to use the old profile
service in order to get the profile name:

http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMessengerWinIntegration.cpp#458

We need to add a thunderbird ifdef to use the new APIs.

Patch coming up.

Comment 1

[Scott MacGregor]

Attachment: possible fix

This fix would work except for one problem :). The toolkit profile service is
not registered with the component manager in the normal startup case. Only when
we are doing the scopeXPCOM startup thing...

http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsAppRunner.cpp#913

Benjamin, do you know why the profile service is unavailable for non startup
consumers? Is there another way for mailnews to get the name of the current
profile like we did with the old profile service API?

Comment 2

[Benjamin Smedberg]

There is no such thing as a current profile name, only a current profile path
(for instance, you can start the program with thunderbird -profile
/path/to/profile. Which is what I think you actually want to do here.

Hrm, I thought I already fixed this code, lemme look and see if I forgot to
check in a file or checked in something similar already.

Comment 3

[Scott MacGregor]

Benjamin, did you happen to find that code snippet you were looking for?

Comment 4

[Scott MacGregor]

Benjamin, did you happen to find that code snippet you were looking for from the
semi-single profile landing? I'd like to get this fixed for 0.8 if we can. Thanks!

Comment 5

[Benjamin Smedberg]

Attachment: use -profile <path> instead of -p <name>

I couldn't find it, so I just re-created it.

Comment 6

[Benjamin Smedberg]

Comment on attachment 156591 [details] [diff] [review]
use -profile <path> instead of -p <name>

Scott, my win32 machine is fried with a bad motherboard, so I can't test this
(or even build it).

Comment 7

[Scott MacGregor]

Attachment: some minor tweaks to make it work