1987235 - 49,000 instances of "NS_ENSURE_TRUE(doc) failed" emitted from dom/workers/WorkerPrivate.cpp during linux2404-64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Andrew McCreight [:mccr8]]

49047 WARNING: NS_ENSURE_TRUE(doc) failed: file dom/workers/WorkerPrivate.cpp:6767

This is the second most common warning on Linux64. It looks like it happens most frequently during shutdown, so it'll be providing a low level of noise across many tests. It happens during the WorkerPrivate::MaybeInheritFontVisibility() function, which was added in bug 1960446.

This warning shows up in 418 test suites. A few of the most prevalent:

   959 - test-linux2404-64/debug-web-platform-tests-8 wpt8
   950 - test-linux2404-64/debug-web-platform-tests-nofis-8 wpt8
   678 - test-linux2404-64/debug-web-platform-tests-7 wpt7
   664 - test-linux2404-64/debug-web-platform-tests-nofis-7 wpt7
   609 - test-linux2404-64/debug-mochitest-devtools-chrome-spi-nw-5 dt5
   609 - test-linux2404-64/debug-mochitest-devtools-chrome-http3-6 dt6
   609 - test-linux2404-64/debug-mochitest-devtools-chrome-5 dt5
   503 - test-linux2404-64/debug-mochitest-devtools-chrome-11 dt11
   476 - test-linux2404-64/debug-web-platform-tests-crashtest Wc
   476 - test-linux2404-64/debug-web-platform-tests-crashtest-swr Wc

It shows up in 9788 tests. A few of the most prevalent:

  4786 -        Shutdown
   396 -        dom/workers/test/crashtests/1228456.html
   297 -        dom/serviceworkers/test/performance/test_update.html
   132 -        dom/serviceworkers/test/test_scopes.html
   117 -        /webdriver/tests/classic/new_session/unhandled_prompt_behavior.py
    95 -        toolkit/components/extensions/test/mochitest/test_ext_scripting_contentScripts.html
    84 -        dom/serviceworkers/test/performance/test_fetch.html
    80 -        browser/components/resistfingerprinting/test/browser/browser_reduceTimePrecision_iframes.js
    77 -        dom/serviceworkers/test/performance/test_registration.html
    76 -        dom/serviceworkers/test/test_install_event.html

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1987235 - Get rid of a frequent warning in WorkerPrivate::MaybeInheritFontVisibility().

This is the 2nd most common warning on Linux.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7e3cb78443a
https://hg.mozilla.org/integration/autoland/rev/4080431c0735
Get rid of a frequent warning in WorkerPrivate::MaybeInheritFontVisibility(). r=dom-worker-reviewers,smaug

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4080431c0735