1754554 - Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/mozilla/Queue.h:223:9 in ShallowSizeOfExcludingThis

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: alissy [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=367288514&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YC4o1p7-TGeNp73N0RGfyg/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[:gerard-majax]

Comment 2

[Andrew McCreight [:mccr8]]

This looks like a race on the memory reporting in ThreadsReporter::CollectReports().

Comment 3

[:gerard-majax]

Attachment: log

Comment 4

[Intermittent Failures Robot]

1 failures in 3711 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1754554&startday=2022-02-07&endday=2022-02-13&tree=all

Comment 5

[Intermittent Failures Robot]

1 failures in 3717 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1754554&startday=2023-01-16&endday=2023-01-22&tree=all

Comment 6

[Intermittent Failures Robot]

1 failures in 3643 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1754554&startday=2023-02-20&endday=2023-02-26&tree=all

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Any chance this is related to bug 1808343?

Comment 8

[Andrew McCreight [:mccr8]]

No. It looks like this race is related to ThreadEventQueue.

If the line numbers haven't changed since the last failure, the memory reporter is on this line:
n += mBaseQueue->SizeOfIncludingThis(aMallocSizeOf);

Bug 1749610 added a lock for mNestedQueues but not mBaseQueue in this function, for whatever reason.

Comment 9

[Andrew McCreight [:mccr8]]

Attachment: TSan report from February 2023

Comment 10

[Andrew McCreight [:mccr8]]

Randell, this might be of interest to you if you are looking for more lock annotations to do, though it looks rather rare.

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

If the line numbers haven't changed since the last failure, the memory reporter is on this line:
n += mBaseQueue->SizeOfIncludingThis(aMallocSizeOf);

Bug 1749610 added a lock for mNestedQueues but not mBaseQueue in this function, for whatever reason.

It make mBaseQueue a const, so how can there be a data race on it? It's never set outside of the constructor

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

It looks more like a race on mHead in Queue.h:233
So the data pointed to by mBaseQueue is getting raced on, not mBaseQueue itself. We can move it inside the lock I think

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1754554: Resolve TSAN issue with mBaseQueue in memory reporting r=mccr8

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddee226cc4d2
Resolve TSAN issue with mBaseQueue in memory reporting r=mccr8

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ddee226cc4d2