153930 - Attachments without suffix are given MIME type application/x-java-vm

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Thomas Bauer]

For java runtime environment plugin versions 1.3.1 as well as 1.4.1,
mail attachments without suffix are given the wrong MIME type.
E.g., if I send somebody a Makefile in an attachment of a mail,
the Makefile gets MIME type application/x-java-vm.
If the user double-clicks on such a file, mozilla crashes.
I am, however, not sure wether this is a problem of mozilla,
or of the JRE plugins themselves.

Comment 1

[Boris 'pi' Piwinger]

I just sent an mbox file to an abuse department (content was a virus). Due to
the absurd content-type the did not want to open it;-)

IOW: Yes, it is a bug and it sucks. If Mozilla cannot determine what a file is
it should ask.

pi

Comment 2

[Henry Jia]

See also bug 141826:  mail attachment with mime application/x-java-vm crashes.

Comment 3

[Yuedong Du]

Attachment: patch for review

When add attatchment, Composer first determine its type by look at its
extension. It call mime service GetTypeFromExtension(). The problem is that the
function do not consider the case that the extension is "". Please refer to
nsExternalHelperAppService.cpp,
nsExternalHelperAppService::GetTypeFromExtension().

In GetTypeFromExtension(), it will search the plugin list, and check extension
list of each type. Don't know why, the java plugin's mExtensionArray[] has a
"", it will thus mistakenly think "" is a plugin type.

Thus when no extension exist should not call the function. And the type of the
attachment can be determined later, when reading the data of the attachment, in
OnDataAvailable(), UnknownDecoder::DetermineContentType() be called.

The patch has passed jst-review-simulacrum.

Comment 4

[Yuedong Du]

I have tested it on solaris and windows.

After the patch:
Attach a binary file without extension, the mime type is application/octet-stream.
Attach a text file without extension, the attachment will be regard as txt file.

Comment 5

[Yuedong Du]

I have tested it on solaris and windows.

After the patch:
Attach a binary file without extension, the mime type is application/octet-stream.
Attach a text file without extension, the attachment will be regard as txt file.

Comment 6

[Jean-Francois Ducarroz]

Great job! Thanks for the patch.

Comment 7

[Jean-Francois Ducarroz]

Comment on attachment 95846 [details] [diff] [review]
patch for review

R=ducarroz

Comment 8

[David :Bienvenu]

Comment on attachment 95846 [details] [diff] [review]
patch for review

sr=bienvenu

Comment 9

[Jean-Francois Ducarroz]

Fix checked in the trunk. Thanks Yuedong Du for providing the patch.

Comment 10

[Thomas Bauer]

Thanks to all, the bug is removed in nightly build 2002082122.

Comment 11

[Henry Jia]

[e-mail] has checked this patch into OEM branch on 8/26.

Mark 'fixedOEM'.

martinl, if something wrong, correct me.

Comment 12

[Boris 'pi' Piwinger]

The fix did not make it into 1.1 release. So it should go into 1.11 if this will be.

pi

Comment 13

[Boris 'pi' Piwinger]

Fix works in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1b) Gecko/20020828.

pi

Comment 14

[Andrew Schultz]

This bug exists on the 1.0 branch as well.  The fix here seems conservative and
prevents a crash.

Comment 15

[Trix Supremo]

changing qa contact to yulian

Comment 16

[Jean-Francois Ducarroz]

*** Bug 178599 has been marked as a duplicate of this bug. ***

Comment 17

[Boris Zbarsky [:bzbarsky]]

As a note, this code should just not use GetFromExtension and use GetFromURI
instead, since it has a URI.  Then the MIME service would properly handle all
the issues like empty extension and such....

Comment 18

[Jean-Francois Ducarroz]

I reopen this bug to implement new suggestion...

Comment 19

[timeless]

Comment on attachment 95846 [details] [diff] [review]
patch for review

mozilla/mailnews/compose/src/nsMsgSend.cpp	1.313

Comment 20

[Ludovic Hirlimann [:Usul]]

(In reply to comment #19)
> (From update of attachment 95846 [details] [diff] [review])
> mozilla/mailnews/compose/src/nsMsgSend.cpp	1.313
> 

Timeless did your last comment meant the bug was fixed ?

Comment 21

[Phil Ringnalda (:philor)]

No, he meant that the original patch was in fact checked in a couple of years before that comment, probably adding that comment as part of some sweep looking for reviewed patches that hadn't ever been checked in.

However, comment 17, for which this was then reopened, isn't so straightforward a decision, so I filed bug 483352 for deciding whether the simplicity is worth dropping the "rename changes the mime-type we send" feature.