1504168 - mozIntl seems to create a new class whenever requesting an Intl constructor

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[André Bargull [:anba]]

Unless things get cached somehow, this [1] will create a completely new JS class whenever the 'NumberFormat' getter is executed. That means for example |mozIntl.NumberFormat === mozIntl.NumberFormat| is |false|.

[1] https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/toolkit/components/mozintl/mozIntl.js#330-337

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1504168 - Stop creating a new instance of a class for each call to mozIntl constructor.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d56f763860a3c877bbd3b2f10a89b27d5dd641df

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36964a9cbf7f
Stop creating a new instance of a class for each call to mozIntl constructor. r=anba

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/36964a9cbf7f