1420129 - Clicking the 'Settings page' link on about:searchreset should go directly to the Search pref pane

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Florian Quèze [:florian]]

This was changed in bug 1335907 that removed the search panel, before it got re-added later (likely in bug 1365133).

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8931316 [details] [diff] [review]
Patch

Review of attachment 8931316 [details] [diff] [review]:
-----------------------------------------------------------------

Tested by inspecting the link in about:searchreset and changing the URL manually. Also, there's a test[1] that opens about:preferences#search and does stuff with the UI, which gives me confidence that this is sane to do.

[1] https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.js#44

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9e5bc0c80e8
Clicking the 'Settings page' link on about:searchreset should go directly to the Search pref pane, r=nhnt11.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8931316 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1335907 and/or bug 1365133
[User impact if declined]: about:searchreset will point users to the general pane of the preferences page
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: Yes
[List of other uplifts needed for the feature/fix]: bug 1419941
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial, covered by test
[String changes made/needed]: none

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8931316 [details] [diff] [review]
Patch

Needed for 57.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/mozilla-beta/rev/248c487966fd5a473458a7f59fa996121af5778d

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/a9e5bc0c80e8

Comment 8

[Adrian Florinescu [:aflorinescu]]

Marking as verified on 58.0b6 - 2017/11/23  on Ubuntu 14.04x32 & Windows 10 x64 & Mac OsX10.12:
- the 'Settings page' link on about:searchreset redirects to about:preferences#search.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/mozilla-release/rev/607be5e86bc0025a7ecb41fb1a53c32c879e0b17

Comment 10

[Adrian Florinescu [:aflorinescu]]

verified also on Nightly  -> 59.0a1 20171126220311

Comment 11

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 x64, Windows 10 x64, macOS 10.13 and Ubuntu 14.04 x64 using Firefox 57.0.1 (buildID: 20171128222554).