Closed
Bug 1387442
Opened 8 years ago
Closed 8 years ago
Add test coverage for AddonRecommender.scala
Categories
(Data Platform and Tools :: General, enhancement, P1)
Data Platform and Tools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
We will need to add proper test coverage to the AddonRecommender.scala model generator. We could do that by feeding it with fake input data, fixing a random seed and making sure that we're getting the expected model out.
[1] - https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/ml/AddonRecommender.scala
|
||
Comment 1•8 years ago
|
||
Alessio, are you actively working on this? Do you plan to work on it in Q4?
Flags: needinfo?(alessio.placitelli)
|
Assignee | |
Comment 2•8 years ago
|
||
(In reply to Mark Reid [:mreid] from comment #1)
> Alessio, are you actively working on this? Do you plan to work on it in Q4?
Hi Mark,
no, I'm not actively working on this but it's something I should really get to in Q4.
Flags: needinfo?(alessio.placitelli)
|
|
||
Updated•8 years ago
|
Points: --- → 2
Priority: -- → P2
|
|
Assignee | |
Comment 3•8 years ago
|
||
Here's the PR: https://github.com/mozilla/telemetry-batch-view/pull/321
Assignee: nobody → alessio.placitelli
|
|
Assignee | |
Updated•8 years ago
|
Priority: P2 → P1
|
|
Assignee | |
Comment 4•8 years ago
|
||
The PR was reviewed and merged.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Comment 5•8 years ago
|
||
Moved to new component, per bug 1425844.
Component: General → Add-on Recommender
|
||
Updated•3 years ago
|
Component: Add-on Recommender → General
You need to log in
before you can comment on or make changes to this bug.
Description
•