Closed Bug 1381138 Opened 8 years ago Closed 8 years ago

browser_urlbarSearchSuggestions_opt-out.js is going to permafail when Gecko 56 merges to Beta

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 + fixed

People

(Reporter: RyanVM, Assigned: evanxd)

References

Details

(Whiteboard: [fxsearch][fixed by bug 1365133])

[Tracking Requested - why for this release]: Test permafail when Gecko 56 merges to Beta in a few weeks. Affects all platforms. https://treeherder.mozilla.org/logviewer.html#?job_id=113641439&repo=try&lineNumber=2613 INFO - TEST-START | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js INFO - TEST-INFO | started process screentopng INFO - TEST-INFO | screentopng: exit 0 INFO - Buffered messages logged at 12:53:38 INFO - Entering test bound prepare INFO - Waiting for engine to be added: searchSuggestionEngine.xml INFO - Search engine added: searchSuggestionEngine.xml INFO - Leaving test bound prepare INFO - Entering test bound focus INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | popup should be open - true == true - INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | "-moz-deck" != "none" - INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | "collapse" == "collapse" - INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | popup should have no results - 0 == 0 - INFO - Buffered messages logged at 12:53:39 INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | true == true - INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | "-moz-deck" != "none" - INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | "visible" == "visible" - INFO - Buffered messages finished INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | Test timed out - INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | popup should be closed - true == true - INFO - GECKO(1692) | MEMORY STAT | vsize 2270MB | residentFast 300MB | heapAllocated 138MB INFO - TEST-OK | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | took 45264ms Screenshot: https://public-artifacts.taskcluster.net/fhULmz6ETGOmKJ07kMQHSg/0/public/test_info//mozilla-test-fail-screenshot_sZF5Mf.png
Component: Preferences → Location Bar
Priority: -- → P1
Whiteboard: [fxsearch]
It is likely related to the about:preferences changes, so indeed the component was not really wrong. We need to handle both cases.
I just took a look - it seems like bug 1365133 should fix this when it lands.
Depends on: 1365133
Ryan, can we count this as fixed since bug 1365133 landed yesterday?
Flags: needinfo?(ryanvm)
Probably, but it would be better for Tomcat or Wes to confirm after a newer simulation run.
Flags: needinfo?(ryanvm)
Wes, can you take a look and confirm this is now fixed?
tracking-firefox56: ? → +
Flags: needinfo?(wkocher)
Do we know if you patch in bug 1365133 also fixes this?
Flags: needinfo?(evan)
Yes, this is fixed by Bug 1365133. We could see browser_urlbarSearchSuggestions_opt-out.js is passed in a 56 beta try[1]. The try log[2]: > [task 2017-07-26T06:11:38.624877Z] 06:11:38 INFO - TEST-START | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js > [task 2017-07-26T06:11:40.547392Z] 06:11:40 INFO - GECKO(1850) | MEMORY STAT | vsize 2380MB | residentFast 444MB | heapAllocated 202MB > [task 2017-07-26T06:11:40.550495Z] 06:11:40 INFO - TEST-OK | browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js | took 1921ms I think we could close this bug. [1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4509c9d0d18fe92f4a2eea7600cfb5a6a0142d&selectedJob=117884414 [2]: https://public-artifacts.taskcluster.net/YCkk-tufTFOM58vCbrL6KQ/0/public/logs/live_backing.log
Flags: needinfo?(evan)
Great, thanks for the testing.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(wkocher)
Resolution: --- → FIXED
Whiteboard: [fxsearch] → [fxsearch][fixed by bug 1365133]
Assignee: nobody → evan
Mark 56 fixed as bug 1365133 was fixed in 56.
status-firefox56: affected → fixed
You need to log in before you can comment on or make changes to this bug.