1377252 - RasterImage::IsUnlocked isn't correct

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement)

Description

[Timothy Nikkel (:tnikkel)]

We currently use RasterImage::IsUnlocked for two different purposes:
1) to determine that we can't throw away the decoded image in WillDrawOpaqueNow
2) to determine when to send the unlockeddraw notification

For 1) what we want to check is mLockCount == 0.

For 2) what we actually want to check is mAnimationConsumers == 0. This is because images that are in the visible list in background tabs will have mLockCount == 0 but mAnimationConsumers > 0 and if we are drawing an image we need to make sure it will be animated (mAnimationConsumers == 0 stops the animation). This is what VectorImage already does.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: isunlocked

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8882327 [details] [diff] [review]
isunlocked

Review of attachment 8882327 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb6cf8e70673
Stop using RasterImage::IsUnlocked because it doesn't do what we want. r=aosmond

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb6cf8e70673