1371702 - Some search results are displayed without favicon in history sidebar

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect, P3)

Description

[Hani Yacoub, Desktop QA]

[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.10 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch Firefox.
2. Start typing in the location bar (e.g yahoo.com).
	*Make sure to access 2 or more pages of same domain
3. Go to bookmark menu and click on "View Bookmarks Sidebar".
4. Type in the search field "yahoo".

[Expected result]:
All search result should be displayed with their correct favicon.

[Actual result]:
Missing favicon from the first suggestion to visit a website

[Note]:
Performing a search in Library returns the same results as in history side bar.

Comment 1

[Graham Perrin]

Testing on FreeBSD-CURRENT. 

At the time of writing, I can't reproduce this bug with either:

- Waterfox 56.1.0_18 (earlier 56.0 was based on Firefox 56.0.2); or 

- Firefox 60.0_2,1. 

Hani, please: can you reproduce the bug with Firefox 60?

Comment 2

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: Screenshot 2024-10-17 141244.png

I have verified this on the latest Firefox Nightly 133.0a1 (2024-10-16), using Windows 11 and macOS 14.7, and the fav icons are displayed for the previously visited webpages with the same domain in history sidebar, but there are still a few URL that do not have a fav icon (for the same domain but different subdomain). Please see the attached ss.

Comment 3

[Marco Bonardo [:mak]]

we may not have a favicon for every url/subdomain, because the site may not define one. And we cannot use the root domain icon for subdomains, because we can't tell what they contain.
Additionally, because this is a Search, is returns also redirecting pages that are very likely to miss a favicon.
I think we can call this bug WFM.
If a specific url, that is not a redirect, doesn't show an icon in Firefox but shows it in another browser, we're happy to investigate that, but it needs its own bug.