1353846 - Add missing #searchResults-native to the native styling on -moz-windows-default-theme: 0

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1335905 added the search results category but failed to add the #searchResults-native rule to browser/themes/windows/preferences/in-content/preferences.css

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1353846 - Add missing #searchResults-native to the native styling on Windows.

Review commit: https://reviewboard.mozilla.org/r/126930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126930/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8855007 [details]
Bug 1353846 - Add missing #searchResults-native to the native styling on Windows.

https://reviewboard.mozilla.org/r/126930/#review129604

::: browser/themes/windows/preferences/in-content/preferences.css:41
(Diff revision 1)
>    #category-advanced > .category-icon {
>      list-style-image: url("chrome://browser/skin/preferences/in-content/icons.svg#advanced-native");
>    }
> +
> +  #category-search-results > .category-icon {
> +    list-style-image: url("chrome://browser/skin/preferences/in-content/icons.svg#search-native");

Shouldn't that be #searchResults-native?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8855007 [details]
Bug 1353846 - Add missing #searchResults-native to the native styling on Windows.

https://reviewboard.mozilla.org/r/126930/#review129606

nm - I was confused. This is fine. :)

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

No, you are right. I'll fix that. Thanks for catching it!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8855007 [details]
Bug 1353846 - Add missing #searchResults-native to the native styling on Windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126930/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82127b1a3d27
Add missing #searchResults-native to the native styling on Windows. r=mconley

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/82127b1a3d27