1344072 - Ship self-uninstall hotfix (from bug 1343982), targeting 39.0 - 52.*

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #1343982 +++

This bug is to deploy the hotfix developed on bug 1343982, which main purpose is to override the currently published hotfix (from bug 1298404), as that is being superseded by the websense-as-system-addon work from bug 1342158.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Unsigned hotfix-v20170302.01.xpi

Jason, could you sign this with the hotfix key? I don't know if there's a special key for it..

Comment 2

[:Felipe Gomes (needinfo for replies!)]

According to the pref extensions.hotfix.certs.2.sha1Fingerprint, the public key is 39:E7:2B:7A:5B:CF:37:78:F9:5D:4A:E0:53:2D:2F:3D:68:53:C5:60

There's also a extensions.hotfix.certs.1.sha1Fingerprint but I believe that's an older, no longer used key.

Comment 3

[Jason Thomas [:jason]]

Attachment: signed hotfix-v20170302.01.xpi

Please see attached. Yes, there is signing certificate unique for hotfix. Signed with Fingerprint=39:E7:2B:7A:5B:CF:37:78:F9:5D:4A:E0:53:2D:2F:3D:68:53:C5:60.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Thanks!

Jorge, can you put this on staging for me to test?

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

The signed file is staged now.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Hi Alexandru, since you did the testing for bug 1342158, could you also do for this one, as they are related?

Steps: do all the changes required to properly receive the system add-on from bug 1342158, but also change:
extensions.update.background.url, by replacing the beginning of the url with

  https://addons-dev.allizom.org  (instead of "https://versioncheck-bg.addons.mozilla.org")


Then, trigger an addons update check, and check that:

- a pref called "extensions.hotfix.lastVersion" gets created with the value "20170302.01"
- a Firefox Hotfix appears in the Add-ons Manager, and disappears after a restart

- it doesn't affect the correct behavior of the system addon, with regards to Websense detection.

Comment 7

[Alexandru Simonca [:asimonca], Release Desktop QA]

Hi Felipe,

Since these bugs are related I've tested them in the same environment as the websense add-ons, as follows:

- Windows 10 x64 with Websense 8.3.2509 installed
- Firefox 49.0.2 x64 & Firefox 50.1.0 x64, both on "release" update channel

I've set the preff "extensions.update.background.url" as you mentioned in the previous comment and then triggered the addon update check.

Actual results:
- the preff "extensions.hotfix.lastVersion" was created with the value "20170302.01"
- the "Firefox Hotfix" did not appear in Add-ons Manager 
- it did not appear to affect the correct behaviour of the system addons

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Thanks, everything looks correct!

I've cleared this with release-drivers and we'll push this live on Thursday

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

The hotfix is now live on prod.