Open Bug 1335009 Opened 8 years ago Updated 3 years ago

Use mozilla::Variant instead of nsIVariant for Scalars

Categories

(Toolkit :: Telemetry, defect, P3)

Product:
Toolkit
Component:
Telemetry
Type:
defect
Points:
2

Tracking

()

Tracking Flags:
Tracking Status
firefox54 --- affected

People

(Reporter: Dexter, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

After bug 1333578 lands, we should get rid of nsIVariant used throughout TelemetryScalar.cpp, replacing it with mozilla::Variant. This task is not too complicated, but has some interesting potential issues like handling passing negative values to unsigned scalars or truncating floating/double numbers.
Blocks: 1275517
Points: --- → 2
Depends on: 1333578
Priority: -- → P2
Whiteboard: [measurement:client]
Priority: P2 → P3

Hi Alessio, I was referred to this bug by :chutten as my second bug I could take on. Do you have any tips on getting started? From looking at the code my understanding is that the datatypes need to be changed, such as changing nsITelemetry to with something in mozilla::Telemetry? Thanks for the help.

(In reply to Jason Ashton from comment #1)

Hi Alessio, I was referred to this bug by :chutten as my second bug I could take on. Do you have any tips on getting started? From looking at the code my understanding is that the datatypes need to be changed, such as changing nsITelemetry to with something in mozilla::Telemetry? Thanks for the help.

Hi Jason! Thanks for asking. I'm afraid that this bug requires a bit of design first, so it's slightly more involved than a second bug. Would you consider taking bug 1168728? It's better scoped :)

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.