1316278 - ATMO V2: Implement dockerflow health check endpoints

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P1)

Description

[Jannis Leidel [:jezdez]]

As mentioned here by :whd ATMO is missing some of the dockerflow health check endpoints

The documentation is *I think* here: https://github.com/mozilla-services/dockerflow#containerized-app-requirements

Quoting the docs:

Respond to /__version__ with the contents of /app/version.json.
Respond to /__heartbeat__ with a HTTP 200 or 5xx on error. This should check backing services like a database for connectivity.
Respond to /__lbheartbeat__ with an HTTP 200. This is for load balancer checks and should not check backing services.

Blake, can you clarify what /__heartbeat__ should specifically check in the case of atmo?

Would a simple request against the Django ORM suffice?

How about Redis, should that be checked, too?

Comment 1

[Blake Imsland [:robotblake]]

I know I keep pointing at them, but normandy [1] looks like they have a good example that uses the Django checks framework [2]. I think checking both database and redis would be a good idea.

[1] https://github.com/mozilla/normandy/tree/master/normandy/health
[2] https://docs.djangoproject.com/en/1.10/topics/checks/

Comment 2

[GitHub Autolander Bot]

Attachment: [telemetry-analysis-service] mozilla:bug1316278 > mozilla:master