Closed
Bug 1312326
Opened 9 years ago
Closed 9 years ago
Use StringFromIPCMessageType for the OOM annotation when enqueue message
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: ting, Assigned: ting)
References
Details
Attachments
(1 file)
Thsi is a followup bug of bug 1309799.
|
Assignee | |
Updated•9 years ago
|
| Comment hidden (mozreview-request) |
|
||
Comment 2•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8803777 [details]
Bug 1312326 - Use StringFromIPCMessageType() instead for better crash annotation.
https://reviewboard.mozilla.org/r/87930/#review86926
Steel review.
::: ipc/glue/MessageChannel.h:484
(Diff revision 1)
> char* topName = nullptr;
> char* curName = nullptr;
These could be |const char*|
::: ipc/glue/MessageChannel.h:498
(Diff revision 1)
> if (curCount > topCount) {
> topName = curName;
> topType = curType;
> topCount = curCount;
> }
> - curName = const_cast<char*>(msg.name());
> + curName = const_cast<char*>(StringFromIPCMessageType(msg.type()));
Then you don't need to const_cast as StringFromIPCMessageType should return |const char*|
Attachment #8803777 -
Flags: review+
| Comment hidden (mozreview-request) |
Pushed by tchou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cf0a592901a
Use StringFromIPCMessageType() instead for better crash annotation. r=kanru
|
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → janus926
You need to log in
before you can comment on or make changes to this bug.
Description
•