Closed Bug 1311506 Opened 9 years ago Closed 8 years ago

Remove devtools/client/promisedebugger

Categories

(DevTools :: Debugger, defect, P1)

Product:
DevTools
Component:
Debugger
Version:
49 Branch
Type:
defect

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file)

Bug 1311506 - Remove promise debugger.
58 bytes, text/x-review-board-request
gl
: review+
Details
The old debugger has a (disabled by default) promise debugger feature. (It is sufficiently disabled that even after using old debugger and enabling "devtools.debugger.promise", it was still hidden AFAICT.) Since this would need to be rewritten for the new debugger anyway, we may want to just remove it at the stage. On IRC, :gl suggested removing may be reasonable.
:gl, :jlongster, thoughts?
Flags: needinfo?(jlong)
Flags: needinfo?(gl)
Let's go ahead with this since there aren't any current resources allocated to working on the promise debugger. We can easily re-add the boilerplate code, but I suspect we will also do a bit of a rewrite to utilize react/redux.
Flags: needinfo?(gl)
Sounds fine to me. I'm not really familiar with it or how much code it is, but if would help to remove it let's do it.
Flags: needinfo?(jlong)
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8804896 [details] Bug 1311506 - Remove promise debugger. https://reviewboard.mozilla.org/r/88722/#review88018
Attachment #8804896 - Flags: review?(gl) → review+
https://hg.mozilla.org/mozilla-central/rev/3d6e90d77c8d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: