1309961 - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_aus_update/updateManagerXML.js

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Jorg K (CEST = GMT+2)]

First seen Thu Oct 13, 2016 here 
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=593964199b659fdb8b5b7d8ce765c1976a783c99&selectedJob=49911
(not the initial push but the Nightly run on the same push).

TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_aus_update/updateManagerXML.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/unit_aus_update/updateManagerXML.js | run_test - [run_test : 145] the update backgroundInterval attribute should equal the expected value - 60 == "600"

Comment 1

[aleth [:aleth]]

The bug won't show up on treeherder without this keyword.

Comment 2

[Jorg K (CEST = GMT+2)]

Looks like this comes from
https://hg.mozilla.org/mozilla-central/rev/3f592df38fe2
https://hg.mozilla.org/mozilla-central/rev/9837e6ec214e
from bug 1309125.

Seems to be caused by app.update.download.backgroundInterval which is set to 60:
https://dxr.mozilla.org/comm-central/search?q=app.update.download.backgroundInterval

Re. comment #1. Sorry, I keep forgetting. Besides, we want to fix this quickly, right? Aleth, can you take a look? What am I missing. Where does the 600 come from?

Comment 3

[aleth [:aleth]]

How is backgroundInterval being set to 600? The corresponding prefs seem to be set to 60. Is there a value in the update.xml now?

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

It appears that somehow that Thunderbird pref is being loaded in the xpcshell test for Thunderbird which I don't think it should be since it is an xpcshell test and the same pref is not loaded when running the xpcshell tests with a Firefox build.

Comment 5

[Robert Strong (they/them - no direct email)]

aleth, could you check if the patch fixes this for Thunderbird?

Comment 6

[aleth [:aleth]]

Unfortunately, it does not seem to have any effect.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ddbac06ad33db8146187641d5a053da58a83d4e9

Comment 7

[Robert Strong (they/them - no direct email)]

I'm building thunderbird to see if I can reproduce.

Comment 8

[Jorg K (CEST = GMT+2)]

That's very kind of you. I was going to do the same since my build predates the landing of the original bug. Sadly it takes about 70 minutes to build which I couldn't squeeze in today.

Comment 9

[Jorg K (CEST = GMT+2)]

You go:
./mozilla/mach xpcshell-test toolkit/mozapps/update/tests/unit_aus_update/updateManagerXML.js
There's no mozilla in front of toolkit/
Just is case you didn't know (since I've met M-C people who didn't know). It's always hard to tell who is a friend of TB and who is a foe ;-)

Comment 10

[Robert Strong (they/them - no direct email)]

No worries and I've been a friend for over 10 years. :)

I even already have a c-c repo locally and build periodically.

Comment 11

[Robert Strong (they/them - no direct email)]

heh... for some reason I thought the failing test was remoteUpdateXML.js and not updateManagerXML.js. The change in the attached patch when made to updateManagerXML.js does fix this bug. I'll take this.

Comment 12

[Robert Strong (they/them - no direct email)]

BTW: it does appear that thunderbird prefs are being applied to xpcshell tests whereas firefox prefs are not. Just a heads up and I'm not going to research as to why.

Comment 13

[Robert Strong (they/them - no direct email)]

Attachment: patch

Since these tests expect that preference to not be set I am removing it in both tests just in case.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/238cebc6be2e
don't allow preferences to interfere with running updateManagerXML.js test. r=mhowell

Comment 15

[:aceman]

You can see where this pref is set in TB:
https://dxr.mozilla.org/comm-central/search?q=app.update.download.backgroundInterval&redirect=false

There is a place that sets it to 600...

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/238cebc6be2e

Comment 17

[Robert Strong (they/them - no direct email)]

(In reply to :aceman from comment #15)
> You can see where this pref is set in TB:
> https://dxr.mozilla.org/comm-central/search?q=app.update.download.
> backgroundInterval&redirect=false
> 
> There is a place that sets it to 600...
See comment #4

Comment 18

[Robert Strong (they/them - no direct email)]

This test fix was landed in bug 1309125 on mozilla-aurora and mozilla-beta