1302005 - Display build architecture (32-bit or 64-bit) to the About dialog

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Adapt Firefox Bug #597738 so About dialog displays build architecture (32-bit or 64-bit)

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1302005.patch

Straight port of bug 597738:
https://hg.mozilla.org/mozilla-central/rev/838a2c3d46ef

Note that the equivalent of "browser" in FF is "messenger" in TB.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1302005.patch

s/Firefox/Thunderbird/ in the localisation note ;-)

Comment 3

[:aceman]

Comment on attachment 8790436 [details] [diff] [review]
1302005.patch

Review of attachment 8790436 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks.

::: mail/base/content/aboutDialog.js
@@ +45,5 @@
>      let buildID = Services.appinfo.appBuildID;
> +    let year = buildID.slice(0, 4);
> +    let month = buildID.slice(4, 6);
> +    let day = buildID.slice(6, 8);
> +    versionField.textContent += ` (${year}-${month}-${day})`;

What is this syntax?

@@ +63,1 @@
>  #ifdef MOZ_UPDATER

I'd love if we also ported the change to AppConstants.MOZ_UPDATER here. In a new bug :)

::: mail/locales/en-US/chrome/messenger/messenger.properties
@@ +826,5 @@
> +# current Thunderbird build: 32-bit or 64-bit. These strings are used in parentheses
> +# after the Thunderbird version in the About dialog,
> +# e.g.: "48.0.2 (32-bit)" or "51.0a1 (2016-09-05) (64-bit)".
> +aboutDialog.architecture.sixtyFourBit = 64-bit
> +aboutDialog.architecture.thirtyTwoBit = 32-bit

They could have added this to the toolkit so we could maybe inherit it.

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #3)
> Works for me, thanks.
Works for me too, on Windows. But the local build is only 32-bit which is soooo uncool.

> What is this syntax?
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Template_literals

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/201a214e959c

Thanks, Wayne, for reporting this.

Comment 6

[:aceman]

(In reply to Jorg K (GMT+2, PTO during summer) from comment #4)
> (In reply to :aceman from comment #3)
> > Works for me, thanks.
> Works for me too, on Windows. But the local build is only 32-bit which is
> soooo uncool.

I've got the 64-bit string so it seems to work for both cases.

> > What is this syntax?
> https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/
> Template_literals

Do they need to drag everything into JS? ;)