1291634 - [Out Of Date Notification] Bar localization is not functioning

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Description]
The Out of Date notification bar is expected to be translated when running a l10n FF build.

[Affected OS]:
-All

[Affected versions]:
44.*

[Prerequisites]:

1. Install Firefox version 44.* l10n French version.
2. Outofdate notifications system add-on required configurations:
2.1 about:config set extensions.systemAddon.update.url to value 	"https://aus5.mozilla.org/update/3/SystemAddons/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/release-sysaddon/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml"
2.2 about:config set extensions.logging.enabled	to value "True"
2.3 about:config Add string app.update.url.override with value "www.softvision.ro" 
3. Set update preferences ->  about:preferences#advanced and set Firefox updates to "Automatically install updates (recommended: improved security)"
4. Force system addons check : Open Tool/WebDeveloper/Web Console and run the snippet:   " Components.utils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck(); "

In the Tools/ WebDeveloper/BrowserConsole a similar line should be listed: "addons.productaddons INFO Downloading from https://ftp.mozilla.org/pub/system-addons/outofdate-notifications/[e-mail] to /tmp/tmpaddon"

5. Restart FF to install the OutOfDate System Addon - !!!! Do not open About:Support to check if updates are being downloaded --> use about:support


[Steps]:
1. Open FF44.* FR localized.

[Expected Result]:
The Out Of Date notification bar is displayed instructing the user that his version of FF is out of date. 
The message displayed should match the l10n, so in this case it should be displayed in French.

[Actual Result]:
The Out Of Date notification message is displayed in English.

[Note]:
The message is displayed in English regardless of the used localization. Cause already identified see https://bugzilla.mozilla.org/show_bug.cgi?id=1280378#c77

Comment 1

[Axel Hecht [:Pike]]

Looking at https://pontoon.mozilla.org/projects/firefox-out-of-date-add-on/, I see the following locales to be green:

ar ast az bg bn-BD cs cy da de dsb el en-GB es-AR es-CL es-ES es-MX et fi fr fy-NL he hr hsb hu id it ja kk ko lv nl nn-NO pa-IN pt-BR pt-PT ru sk sl sq sr sv-SE te tr uk uz zh-CN zh-TW

For these, we should add the chrome.manifest entries, and not for those that are not at a 100% green.

Yes, I did some devtools mangling to get that ;-)

Comment 2

[Francesco Lodolo [:flod] (OOO Oct 3–10)]

Just pointing out that webstatus has a basic API to show complete locales (it should be added to Pontoon at some point)
https://l10n.mozilla-community.org/webstatus/api/?product=outofdate-notifications-system-addon&type=complete&txt

Also, pl is complete but not available in Pontoon.

Comment 3

[Stephen A Pohl [:spohl]]

I've updated the chrome.manifest and it now looks as follows. en-US is placed first to be used as fallback language in case a particular locale couldn't be found in the manifest:

locale outofdate-notifications en-US locales/en-US/
locale outofdate-notifications ar locales/ar/
locale outofdate-notifications ast locales/ast/
locale outofdate-notifications az locales/az/
locale outofdate-notifications bg locales/bg/
locale outofdate-notifications bn-BD locales/bn-BD/
locale outofdate-notifications cs locales/cs/
locale outofdate-notifications cy locales/cy/
locale outofdate-notifications da locales/da/
locale outofdate-notifications de locales/de/
locale outofdate-notifications dsb locales/dsb/
locale outofdate-notifications el locales/el/
locale outofdate-notifications en-GB locales/en-GB/
locale outofdate-notifications es-AR locales/es-AR/
locale outofdate-notifications es-CL locales/es-CL/
locale outofdate-notifications es-ES locales/es-ES/
locale outofdate-notifications es-MX locales/es-MX/
locale outofdate-notifications et locales/et/
locale outofdate-notifications fi locales/fi/
locale outofdate-notifications fr locales/fr/
locale outofdate-notifications fy-NL locales/fy-NL/
locale outofdate-notifications he locales/he/
locale outofdate-notifications hr locales/hr/
locale outofdate-notifications hsb locales/hsb/
locale outofdate-notifications hu locales/hu/
locale outofdate-notifications id locales/id/
locale outofdate-notifications it locales/it/
locale outofdate-notifications ja locales/ja/
locale outofdate-notifications kk locales/kk/
locale outofdate-notifications ko locales/ko/
locale outofdate-notifications lv locales/lv/
locale outofdate-notifications nl locales/nl/
locale outofdate-notifications nn-NO locales/nn-NO/
locale outofdate-notifications pa-IN locales/pa-IN/
locale outofdate-notifications pl locales/pl/
locale outofdate-notifications pt-BR locales/pt-BR/
locale outofdate-notifications pt-PT locales/pt-PT/
locale outofdate-notifications ru locales/ru/
locale outofdate-notifications sk locales/sk/
locale outofdate-notifications sl locales/sl/
locale outofdate-notifications sq locales/sq/
locale outofdate-notifications sr locales/sr/
locale outofdate-notifications sv-SE locales/sv-SE/
locale outofdate-notifications te locales/te/
locale outofdate-notifications tr locales/tr/
locale outofdate-notifications uk locales/uk/
locale outofdate-notifications uz locales/uz/
locale outofdate-notifications zh-CN locales/zh-CN/
locale outofdate-notifications zh-TW locales/zh-TW/

Comment 4

[Adrian Florinescu [:aflorinescu]]

Stephen, is it possible to use an artifice in order to be able to test this without waiting until the addon is updated with this change? I am thinking of manually updating the chrome manifest with the above lines. Would that work?

Comment 5

[Stephen A Pohl [:spohl]]

None that I'm aware of. Changing the manifest will break the signature and the addon will no longer run.

Comment 6

[Stephen A Pohl [:spohl]]

Attachment: Fix localization by adding locales to chrome.manifest

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 8777605 [details] [review]
Fix localization by adding locales to chrome.manifest

lgtm, can't review the telemetry pieces, though.

Only question I'd have is wether you tested the add-on in RTL?

Comment 8

[Stephen A Pohl [:spohl]]

Thank you! Yes, the telemetry pieces are getting their dedicated attention in bug 1284652.

I haven't been able to test RTL since we need the addon to be signed and staged. Adrian, could you run a test for RTL when verifying this? Thanks!

Comment 9

[Stephen A Pohl [:spohl]]

https://github.com/mozilla/outofdate-notifications-system-addon/pull/8 has been merged. New addon is being signed and uploaded in bug 1292243.

Comment 10

[Stephen A Pohl [:spohl]]

I just verified that we're now delivering version 1.3 of the addon, which is supposed to be properly localized for the locales listed in this bug. I've also verified that Firefox in French properly displays the notification bar and button in French.

Adrian, if you could please verify this bug on your end and also check RTL, I would appreciate it. Thanks!

Comment 11

[Stephen A Pohl [:spohl]]

I've just verified that the unlocalized locale "ro" in Firefox 44.0.2 on OSX properly displays the notification bar and button in English. The main question remaining is RTL.

Comment 12

[Adrian Florinescu [:aflorinescu]]

Verified this fix on 44.* on Win 8.1, Win7, Mac OSX 10.11, Windows XP, Win 10 and also for RTL arabic.
Also, verified the language the OutOfDate notification is defaulted to is en-us in the case the translation is not available ("ro")