1282091 - Adjust the "scalars" format in the main ping

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

The scalars are landing, but no consensus was reached on the right format to store parent/content data in bug 1281795.

This bug is about fixing the format depending on the outcome of bug 1281795.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Bug 1281795 has an agreed-upon format, so lets do this for scalars now.

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1282091.patch

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8767672 [details] [diff] [review]
bug1282091.patch

Review of attachment 8767672 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +1282,3 @@
>      // Notify that there was a subsession split in the parent process.
>      if (isSubsession && clearSubsession) {
>        Services.obs.notifyObservers(null, "telemetry-subsession-split", "");

Nit: I would stack the changes the other way around.
That way we never have a real usage of the previous format landed.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: bug1282091.patch

Comment 5

[Alessio Placitelli [:Dexter]]

(In reply to Georg Fritzsche [:gfritzsche] [away Jun 24 - Jul 3] from comment #3)
> Comment on attachment 8767672 [details] [diff] [review]
> bug1282091.patch
> 
> Review of attachment 8767672 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/telemetry/TelemetrySession.jsm
> @@ +1282,3 @@
> >      // Notify that there was a subsession split in the parent process.
> >      if (isSubsession && clearSubsession) {
> >        Services.obs.notifyObservers(null, "telemetry-subsession-split", "");
> 
> Nit: I would stack the changes the other way around.
> That way we never have a real usage of the previous format landed.

Good point. I've rebased the patch and also dealt with about:telemetry, which was still using the old format.

Comment 6

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e781684221d

Comment 7

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/55e7347982396d56cecfe347c3f2d73562716216
Bug 1282091 - Adjust the "scalars" format in the main ping. r=gfritzsche

Comment 8

[Georg Fritzsche [:gfritzsche]]

This needs documentation - follow-up bug?

Comment 9

[Alessio Placitelli [:Dexter]]

Filed bug 1284572.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55e734798239

Comment 11

[Georg Fritzsche [:gfritzsche]]

Can you submit a PR to the pipeline schemas?

Comment 12

[Alessio Placitelli [:Dexter]]

There we go: https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/9