1274319 - [Elevated Update] Fast Elevation Cancel hangs Firefox

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Description]:
If at the point when the elevated authentication window is displayed a fast cancel is pressed, Nightly will hang.

[Steps to Reproduce]:
1. Install Nightly from Admin account.
2. Switch to standard account.
3. Check for update, download and restart to update.
4. When the elevated authentication window is displayed press a fast Cancel.

[Actual Result]:
The loading panel remains stuck.

[Expected Result]:
The loading panel is closed and Nightly process doesn't hang.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Patch

The issue is identical to what we've fixed in bug 1268475 for |ObtainUpdaterArguments|. This time it's |CleanupElevatedMacUpdate| that may fail to connect to the unelevated update process if the elevation dialog gets dismissed too quickly. These two functions are the only two that suffer from this problem. I've refactored the code a bit to make this cleaner.

Comment 2

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/projects/oak/rev/d0433d871cf8a7aa43dfbcbe245f2d41e9046a74
Bug 1274319: Allow elevated updater on OSX to make 10 IPC connection attempts to the unelevated updater. r=mstange CLOSED TREE

Comment 3

[Stephen A Pohl [:spohl]]

Thanks, Markus!

Adrian, please verify with this build:
http://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-19-14-34-16-oak/firefox-49.0a1.en-US.mac.dmg

Thanks!

Comment 4

[Adrian Florinescu [:aflorinescu]]

Verified the fix and the issue is still reproducible; reopening issue.

Comment 5

[Stephen A Pohl [:spohl]]

Attachment: Patch

The previous patch fixed the updater binary. However, in the case reported here, it is actually the Firefox process that tries to launch the privileged helper tool and causes the elevation dialog to display. Hence, it is Firefox's responsibility to clean up the unelevated updater process if the user cancels the elevation dialog. This patch adds the same fix to toolkit/xre/MacLaunchHelper.mm. Sorry to bother you again, Markus. We should be in the clear now.

Comment 6

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/projects/oak/rev/fac56d4f0fd7e86d04f5bd397dc576ef9ddf19ac
Bug 1274319: Allow elevated updater on OSX to make 10 IPC connection attempts to the unelevated updater. r=mstange

Comment 7

[Stephen A Pohl [:spohl]]

Please verify with this build:
http://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-20-21-29-41-oak/firefox-49.0a1.en-US.mac.dmg

Thanks!

Comment 8

[ovidiu boca[:Ovidiu]]

Hi Stephen,

I verified this issue on Mac OS 10.9, 10.10 and 10.11 with the build from comment 7.
 On OS 10.10 I couldn't reproduce the issue but on the other systems it can be reproduced. The actual results are the same: the loading panel remains stuck after the cancellation. 
Please note that I also tested OS 10.10 on MacBook and the issue doesn't reproduce!?
I will retest this issue as soon as the feature becomes available in the Nightly build.

Comment 9

[Stephen A Pohl [:spohl]]

When you verify this on Nightly, please make sure to check the console and the update log for any messages if the issue reproduces.

Comment 10

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0982c4e30cfbc79ef1f4e25c4a1afb0766cfec
Bug 1274319: Allow elevated updater and Firefox on OSX to make 10 IPC connection attempts to the unelevated updater. r=mstange

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba0982c4e30c

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Cornel, can someone from your team re-test this with a newer build?   
Robert should this uplift after verification (to 49 aurora?)

Comment 13

[Robert Strong (they/them - no direct email)]

This should already be on 49.

Stephen, please confirm.

Comment 14

[Stephen A Pohl [:spohl]]

Yes, this is in 49.

Comment 15

[Bogdan Maris, Desktop Test Engineering]

This is still reproducible only on Mac OS X 10.9.5 using both Nightly and Aurora from 2016-07-08. Same steps as in comment 0. Mac OS X 10.10.5 and 10.11 are not affected.
Should we reopen this bug or log a new one?

Comment 16

[Stephen A Pohl [:spohl]]

Since this only affects a subset of systems, please file a new bug. It probably also shouldn't have a rating of "major" anymore. It arguably never was a major issue, because most users wouldn't click cancel this fast.

When you file the new bug, please make sure to follow comment 9.