1261738 - Too many "FX_TAB_SWITCH_TOTAL_MS was already initialized" errors in tests

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Kris Maglione [:kmag]]

When tests trigger tab switches in quick succession, we wind up with a lot of overlapping tab switch stopwatches, and the resulting floods of errors make test output extremely difficult to deal with.

Comment 1

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1261738: Try to avoid overlapping FX_TAB_SWITCH_TOTAL_MS stopwatches. r?mconley

Review commit: https://reviewboard.mozilla.org/r/44061/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44061/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8737668 [details]
MozReview Request: Bug 1261738: Try to avoid overlapping FX_TAB_SWITCH_TOTAL_MS stopwatches. r?mconley

https://reviewboard.mozilla.org/r/44061/#review40813

LGTM - thanks for plugging that. :)

::: browser/base/content/tabbrowser.xml:1020
(Diff revision 1)
>            <![CDATA[
>              this.ownerDocument.title = this.getWindowTitleForBrowser(this.mCurrentBrowser);
>            ]]>
>          </body>
>        </method>
>  

Mind adding a quick comment here explaining what this is being used for?

Comment 4

[Kris Maglione [:kmag]]

https://reviewboard.mozilla.org/r/44061/#review40813

> Mind adding a quick comment here explaining what this is being used for?

Sure.

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/99272d590c8ff6925f7b9c2471be88b0ba373174
Bug 1261738: Try to avoid overlapping FX_TAB_SWITCH_TOTAL_MS stopwatches. r=mconley

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/99272d590c8f