1257209 - Record uptime in crash events/crash telemetry pings

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Benjamin Smedberg]

Currently we don't record uptime in crash telemetry pings, which means that we can't distinguish some things like startup and shutdown crashes. Easy to fix and valuable.

Comment 1

[Benjamin Smedberg]

Attachment: MozReview Request: Bug 1257209 - record uptime in crash metadata/pings, r?gfritzsche

Review commit: https://reviewboard.mozilla.org/r/40565/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40565/

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8731415 [details]
MozReview Request: Bug 1257209 - record uptime in crash metadata/pings, r?gfritzsche

https://reviewboard.mozilla.org/r/40565/#review37665

::: toolkit/crashreporter/test/unit/test_event_files.js:52
(Diff revision 1)
>    let crash = crashes[0];
>    Assert.ok(crash.isOfType(cm.PROCESS_TYPE_MAIN, cm.CRASH_TYPE_CRASH));
>    Assert.equal(crash.id + ".dmp", basename, "ID recorded properly");
>    Assert.equal(crash.metadata.ShutdownProgress, "event-test");
>    Assert.ok("TelemetrySessionId" in crash.metadata);
> +  Assert.ok("UptimeTS" in crash.metadata);

We should test for "CrashTime" too.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/428290912512

Comment 4

[Benjamin Smedberg]

Comment on attachment 8731415 [details]
MozReview Request: Bug 1257209 - record uptime in crash metadata/pings, r?gfritzsche

Approval Request Comment
[Feature/regressing bug #]: Not a regression, but this is required to properly analyze some issues for the UT-based crash dashboards tracked in bug 1257321
[Describe test coverage new/current, TreeHerder]: Manual and automated tests
[Risks and why]: This is low risk: it adds one new property
[String/UUID change made/needed]: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/428290912512

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8731415 [details]
MozReview Request: Bug 1257209 - record uptime in crash metadata/pings, r?gfritzsche

Improving crash metadata to help make informed decisions re: release quality and severity of issues, Aurora47+, Beta46+

Comment 7

[Carsten Book [:Tomcat]]

has problems to apply to aurora:

grafting 335152:428290912512 "Bug 1257209 - record uptime in crash metadata/pings, r=gfritzsche"
merging toolkit/crashreporter/nsExceptionHandler.cpp
merging toolkit/crashreporter/test/unit/test_event_files.js
warning: conflicts while merging toolkit/crashreporter/test/unit/test_event_files.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)

Comment 8

[Benjamin Smedberg]

Bug 1187270 which is pending approval will solve the conflict.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b424b3c0b111

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm hitting conflicts uplifting this to beta, likely because bug 1240160 isn't on beta.

Comment 11

[Carsten Book [:Tomcat]]

in risk of missing beta 5

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

I asked in bug 1240160 if we should uplift. Benjamin, this is probably going to miss beta 5 but we could get it in for beta 6. If we need to hold back beta 5 for an hour or two though to do these uplifts, let me know.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking so we keep an eye on this still needing to land.

Comment 14

[Benjamin Smedberg]

https://hg.mozilla.org/releases/mozilla-beta/rev/ceb34be0c797