Closed
Bug 1250849
Opened 10 years ago
Closed 9 years ago
Close hooks & other listeners are added each time the panel is opened
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: dcritchley)
References
()
Details
(Whiteboard: [btpp-fix-now][47])
Attachments
(1 file)
We've just been debugging some issues around the panel.
We noticed that in bootstrap.js LoopUI -> openPanel we're re-adding the listeners every time the window is open (i.e. calling hookWindowCloseForPanelClose, addMessageListener etc).
We should put in some protection to stop that, and to remove the listeners on shutdown.
Note: bug 1229352 is affecting some of the panel unloading process, so we fix some of this in that, or wait until that is completed.
|
||
Updated•10 years ago
|
Whiteboard: [tech-debt][triage]
|
|
||
Updated•10 years ago
|
Rank: 22
Priority: -- → P2
Whiteboard: [tech-debt][triage] → [tech-debt][btpp-fix-now]
|
|
||
Updated•10 years ago
|
Whiteboard: [tech-debt][btpp-fix-now] → [btpp-fix-now]
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dcritchley
|
Reporter | |
Comment 1•9 years ago
|
||
This feels like value for users who use Hello a lot. Its also probably going to affect when we go restartless - bug 1229352.
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8742547 -
Flags: review?(standard8)
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8742547 [details] [review]
[loop] daveccrit:1250849-CloseHooks > mozilla:master
Looks good r=Standard8
Attachment #8742547 -
Flags: review?(standard8) → review+
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•