1246486 - Port Bug 1192921 to Seamonkey. System addons directory missing in Seamonkey profile.

Status: NEW

(SeaMonkey :: General, defect)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1192921 added a system addons directory in Firefox. This is missing in Seamonkey.

Because of this you will see occational errors in the web console.

>> Timestamp: 2/7/2016 12:30:22 PM
>> Error: 1454844622328	addons.xpi	ERROR	Failed to clean updated 
>> system add-ons directories.: Win error 2 during operation 
>> DirectoryIterator.prototype.next on file C:\Users\NO1\AppData\Roaming
>> \Mozilla\SeaMonkey\Profiles\es9uf9xh.default\features 
>> (The system cannot find the file specified.)
>> ((unknown module)) No traceback available
>> Source File: resource://gre/modules/Log.jsm
>> Line: 751

Seems to be harmless and not cause any trouble.

Comment 1

[Frank-Rainer Grahl (:frg)]

Workaround:

Manually add an empty features directory to your profile.

Comment 2

[Frank-Rainer Grahl (:frg)]

See also Bug 1229974 for Thunderbird

Comment 3

[Dave Townsend [:mossop]]

We see the same errors on Firefox too, I would be fine with just making the add-ons manager code not log in that case.

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to Dave Townsend [:mossop] from comment #3)
> We see the same errors on Firefox too, I would be fine with just making the
> add-ons manager code not log in that case.

yep, AFAICT bug 1192921 canges only two files, both in the toolkit tree (toolkit/mozapps/extensions/internal/XPIProvider.jsm and toolkit/mozapps/extensions/internal/XPIProviderUtils.js), with no #ifdef that I can see.

Dave, am I right in thinking that this bug should be regarded as a Toolkit/Add-ons Manager bug, and in fact a followup to bug 1192921, affecting all three of Firefox, Thunderbird and seaMonkey in the same manner? This of course doesn't mean that SeaMonkey volunteers should be barred from proposing a patch (if any of them is willing) but it makes a difference about who would be qualified to review such a patch.

Comment 5

[Frank-Rainer Grahl (:frg)]

I think the logging shouldn't be completly supressed. Created toolkit Bug 1246614 and submitted a patch.



FRG

Comment 6

[Frank-Rainer Grahl (:frg)]

The reported error in the log should be fixed but I think this bug should be kept open because we do need to add the system addons directory to the profiles in the future.