1242097 - Support sync module for logging

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

I've been using NSPR logging to debug some IPC crashes, but it's not too useful if the log doesn't get flushed on every write. The last writes are usually the most interesting. This patch adds support for the artificial "sync" module, which NSPR already seems to support.

Comment 1

[Eric Rahm [:erahm]]

Comment on attachment 8711261 [details] [diff] [review]
patch

Review of attachment 8711261 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thank you for adding this missing NSPR feature.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62eaf89ab82f

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out as part of these two commmits:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f8be949a7397
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/928befa33041

Something from this or bug 1240985 caused near permafails like https://treeherder.mozilla.org/logviewer.html#?job_id=20470069&repo=mozilla-inbound

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57e9eb4ed010

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/57e9eb4ed010

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/57e9eb4ed010