1241916 - [gn] Add gn locale to browser/locales/shipped-locales for Fx45

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jeff Beatty [:gueroJeff]]

Attachment: add-gn-shipped-locales.patch

The Guaraní (gn) locale is ready to be added to shipped-locales for Aurora and Beta. The attached patch adds the locale for Aurora, but we'd like this to also be ported to Beta. Also, please do not reset all-locales and shipped-locales during merge day. As usual, this is not going to land on mozilla-central, as the l10n config there is just for nightly.

As I do not have commit access, this patch will need to be commited for me please.

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Comment on attachment 8711028 [details] [diff] [review]
add-gn-shipped-locales.patch

Looks good to me. r+

Comment 2

[Jeff Beatty [:gueroJeff]]

Hey Ryan,

I need to get this patch landed before merge day. Could you take a look at it for me please for mozilla-aurora landing permission? The questions didn't pop up for me when I flagged it. The risk here is low, especially as long as we do not reset all-locales and shipped-locales during merge day.

Thanks,
Jeff

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Release Management handles approvals, not me.

Comment 4

[Jeff Beatty [:gueroJeff]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> Release Management handles approvals, not me.

Thank you. Sorry for the confusion.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8711028 [details] [diff] [review]
add-gn-shipped-locales.patch

Sure

Comment 6

[Jeff Beatty [:gueroJeff]]

Thank you. Can we make sure this gets landed and ported to Beta today so we get Beta builds for this locale out as early as possible please?

Comment 7

[Carsten Book [:Tomcat]]

 https://hg.mozilla.org/releases/mozilla-beta/rev/3bc504ea394f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Landed on Aurora46 as well.
https://hg.mozilla.org/releases/mozilla-aurora/rev/302ab550a227

Comment 9

[Jeff Beatty [:gueroJeff]]

Thanks all!

Comment 10

[Sylvestre Ledru [:Sylvestre]]

This broke the build
2016-01-27 01:28:34,686 : INFO : Comparing l10n changesets on dashboard https://l10n.mozilla.org/shipping/l10n-changesets?ms=fx45_beta_b1 to on-disk buildbot-configs/mozilla/l10n-changesets_mozilla-beta ...
2016-01-27 01:28:35,331 : INFO : Comparing l10n changesets to shipped locales ...
2016-01-27 01:28:35,332 : ERROR : l10n_changesets and shipped_locales differ on locales: ['gn']
2016-01-27 01:28:35,332 : ERROR : Error verifying l10n_changesets matches shipped_locales

l10n.m.o didn't provide the l10n changeset for this locale. I went on https://hg.mozilla.org/releases/l10n/mozilla-beta/gn
and used  2b9bb3cc4e54 as changeset

Comment 11

[Carsten Book [:Tomcat]]

backed out from beta in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=fa05149b610d

Comment 12

[Jeff Beatty [:gueroJeff]]

Can we land this again? Should I approve a changeset sign-off before it lands?

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Yes, we can. 
Please sign off when you can. Thanks!

Comment 14

[Jeff Beatty [:gueroJeff]]

Awesome! I signed off on revision 9846a32f9c8f.

Comment 15

[Jeff Beatty [:gueroJeff]]

Is there anything more we need to do? Can we land this again before Beta 2 please?

Comment 16

[Carsten Book [:Tomcat]]

sylvestre is this ok to land now ?

Comment 17

[Axel Hecht [:Pike]]

Grabbing that needinfo from Sylvestre, as I have the data.

Yes, this is good to land now, and should land before the GTB for Beta 2.

Flagging back the needinfo for landing, lacking a better idea of how to flag my intent.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/32bb82b87b60

Comment 19

[Axel Hecht [:Pike]]

Thanks.

Comment 20

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected