Open Bug 1239333 Opened 10 years ago Updated 3 years ago

Refactor the code to wait on environment changes to promiseEnvironmentChange

Categories

(Toolkit :: Telemetry, defect, P4)

Product:
Toolkit
Component:
Telemetry
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox46 --- affected

People

(Reporter: Dexter, Unassigned)

References

Details

(Whiteboard: [measurement:client])

We could greatly simplify the code in test_TelemetryEnvironment.js (and possibly other tests) by refactoring all those manual and duplicated approaches to wait on an environment change into one helper like promiseEnvironmentChange(). Or a class that gives you per-test-instances that allow waiting on changes and do the counting etc. for you. See https://dxr.mozilla.org/mozilla-central/rev/e790bba372f14241addda469a4bdb7ab00786ab3/toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js#767,778
Blocks: 1137262
Whiteboard: [measurement:client]
Priority: -- → P3
Priority: P3 → P4
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.