1230999 - Add an option for tap-to-view images to block images on slow cell networks

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

This might be approaching overkill, but I see that Google recently added this support to Chrome [1]. We could add a "Blocked on slow networks" option and use nsINetworkService to look for 2G or slower networks. We already use the service to look for Wifi.

Shouldn't block shipping Tap-to-view images.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #0)
> This might be approaching overkill, but I see that Google recently added
> this support to Chrome [1].

[1] http://www.cnet.com/news/google-chromes-new-data-saver-feature-update-allows-you-to-save-70-of-your-mobile-data/

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #0)
> We could add a "Blocked on slow networks" option
> and use nsINetworkService to look for 2G or slower networks

I meant nsINetworkLinkService:
http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsINetworkLinkService.idl#22

Comment 3

[Jonathan Almeida [:jonalmeida]]

Seems doable, but this would seem like a confusing option to have.

Show Images
 - Always
 - Only on Wifi
 - On slow data
 - Blocked

If there's a way to fix it, I wouldn't mind adding a 'Allow smaller images' if we don't add bug 1211296 in by default.

Comment 4

[Jonathan Almeida [:jonalmeida]]

I'll try to have a patch for this soon to see how it looks/works.

Will test it out on an emulator[1] while I find a way to emulate slow networks on an actual device.

[1]: http://stackoverflow.com/a/7026341

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Jonathan Almeida (:jonalmeida) from comment #3)
> Seems doable, but this would seem like a confusing option to have.
> 
> Show Images
>  - Always
>  - Only on Wifi
>  - On slow data
>  - Blocked

Maybe:

 Show Images
  - Always show
  - Show only on Wifi
  - Blocked on slow data
  - Always blocked

Comment 6

[Jonathan Almeida [:jonalmeida]]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> (In reply to Jonathan Almeida (:jonalmeida) from comment #3)
> > Seems doable, but this would seem like a confusing option to have.
> > 
> > Show Images
> >  - Always
> >  - Only on Wifi
> >  - On slow data
> >  - Blocked
> 
> Maybe:
> 
>  Show Images
>   - Always show
>   - Show only on Wifi
>   - Blocked on slow data
>   - Always blocked

Thinking about this a bit more, choosing 'Blocked on slow data' would mean you loose the option to select 'Slow only on Wifi' as well.

I wonder if removing 'Always blocked' and blocking on slow data would be better, or make it an implicit option along with another one.

</late_night_thoughts>

Comment 7

[Jonathan Almeida [:jonalmeida]]

Attachment: Add an option for tap-to-view images to block images on slow cell networks

Comment 8

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 8697191 [details] [diff] [review]
Add an option for tap-to-view images to block images on slow cell networks

I haven't had much success testing this out with an emulator or device since the ways I've found to throttle network connectivity won't change my network type to 2G.

This should still work if possible. I think we can do better with the option though; it still seems off.

I made an apk with my patch available as well: http://fennec.surge.sh//app-slow-network-bug-1230999.apk

Comment 9

[Jonathan Almeida [:jonalmeida]]

Unassigning. I'm not actively working on this.

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.