1221094 - Not using tiles for PaintedLayers inside scrolled active transforms

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

Attachment: testcase

If you scroll the testcase with paint flashing on, you'll see regular invalidations of the whole page because the SingleTiledContentClient is resized as different amounts of text are put into the display port.

We're not using tiles here because the loop inside ContainerState::GetLayerCreationHint stops at mContainerAnimatedGeometryRoot.

Comment 1

[Markus Stange [:mstange]]

Hmm, using tiles here doesn't prevent the invalidations.

Comment 2

[Markus Stange [:mstange]]

Attachment: use-tiles

Comment 3

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e2affd8a39f

Comment 4

[Markus Stange [:mstange]]

The invalidations are actually a new manifestation of bug 1164227 (invalid region simplification crosses unchanged stuff in the middle) and I'll file a new bug about them.

Comment 5

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1221094 - Don't mutate local mParameters with stuff that we only want to pass somewhere else. r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/29279/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29279/

Comment 6

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1221094 - Detect scrollability (for using tiled layers) through container layers. r?mattwoodrow

Review commit: https://reviewboard.mozilla.org/r/29281/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29281/

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8703140 [details]
MozReview Request: Bug 1221094 - Don't mutate local mParameters with stuff that we only want to pass somewhere else. r?mattwoodrow

https://reviewboard.mozilla.org/r/29279/#review26945

Comment 8

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8703141 [details]
MozReview Request: Bug 1221094 - Detect scrollability (for using tiled layers) through container layers. r?mattwoodrow

https://reviewboard.mozilla.org/r/29281/#review26947

Comment 9

[Markus Stange [:mstange]]

This causes layout/reftests/bugs/1078262-1.html to fail on B2G:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b37065fb708c&selectedJob=15281327

It looks like there are black seams between the tiles in the layer for #inner, which doesn't make any sense to me.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d40b86b8cc1
https://hg.mozilla.org/integration/mozilla-inbound/rev/70f69c94da8c
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5d0a9a548fe

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d40b86b8cc1
https://hg.mozilla.org/mozilla-central/rev/70f69c94da8c
https://hg.mozilla.org/mozilla-central/rev/d5d0a9a548fe