1219733 - Allow "bug_numbers" field in Histograms.json

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Georg Fritzsche [:gfritzsche]]

Per this thread we now require bug numbers in Telemetry probe descriptions:
https://mail.mozilla.org/pipermail/fhr-dev/2015-October/000655.html

However, it would be much better to keep that data in a separate field "bug_number".
We can allow that field from the Python script now and later backfill the field for old entries from hg history, then make it a required field.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Allow a 'bug_numbers' field in Histograms.json entries

This allows for an array of bug numbers, as discussed on IRC.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Also added first example entries for the bug 1162538 histograms to make sure this builds properly.

Comment 3

[Vladan Djeric (:vladan)]

Comment on attachment 8680647 [details] [diff] [review]
Allow a 'bug_numbers' field in Histograms.json entries

Review of attachment 8680647 [details] [diff] [review]:
-----------------------------------------------------------------

Mark my other email address ([e-mail]) for reviews in the future, this review didn't show up in my Bugzilla dash :(

::: toolkit/components/telemetry/Histograms.json
@@ +4725,5 @@
>      "kind": "linear",
>      "high": "13",
>      "n_buckets": 12,
> +    "description": "Number of directories in the archive at scan",
> +    "bug_numbers": [1162538]

very small nit: i prefer the last line to be the description :)

::: toolkit/components/telemetry/histogram_tools.py
@@ +239,5 @@
> +        if not isinstance(bug_numbers, list):
> +            raise ValueError, 'bug_numbers field for "%s" should be an array' % (name)
> +
> +        if not all(type(num) is int for num in bug_numbers):
> +            raise ValueError, 'bug_numbers array for "%s" should only contain numbers' % (name)

numbers -> integers

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/be3cc4130caf

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be3cc4130caf

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/be3cc4130caf

Comment 7

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 8

[Chris H-C :chutten|PTO (back Oct 23)]

How would you feel about uplifting this to 44? I need to uplift bug 1198209 and it wouldn't be the first time my patch burned in aurora because of a stray bug_numbers field :S

Comment 9

[Georg Fritzsche [:gfritzsche]]

Sure, there is no client-side risk here.

Comment 10

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8680647 [details] [diff] [review]
Allow a 'bug_numbers' field in Histograms.json entries

Approval Request Comment
[Feature/regressing bug #]: Telemetry.
[User impact if declined]: This allows a "bug_numbers" field in our histogram description, so we can link them to the bug history.
[Describe test coverage new/current, TreeHerder]: None needed, was fine on m-c.
[Risks and why]: No client-risk, this just adds a field for human or server-side consumption.
[String/UUID change made/needed]: None.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8680647 [details] [diff] [review]
Allow a 'bug_numbers' field in Histograms.json entries

This has been on m-c for almost a month, seems safe to uplift to Aurora44.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7eb32432b337

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7eb32432b337