1219322 - Document payload.info.flashVersion and payload.info.addons

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

v4 ping payloads contain |payload.info.flashVersion| and |payload.info.addons|, but are not documented.

Those fields are going to be removed when bug 1201837 lands, but still it's worth documenting them to prevent confusion: the environment data should be preferred over flashVersion & addons.

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1219322.patch

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8680103 [details] [diff] [review]
bug1219322.patch

Review of attachment 8680103 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/main-ping.rst
@@ +42,5 @@
>          sessionLength: <number>, // the session length until now in seconds, monotonic
>          subsessionLength: <number>, // the subsession length in seconds, monotonic
> +
> +        flashVersion: <string>, // to be removed, use ``environment.addons.activePlugins``
> +        addons: <string>, // to be removed, use ``environment.addons``

I would say "obsolete" instead.

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: bug1219322.patch

Comment 4

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/b836b8feea9ee7b53475dd122ff388aa6fcd37f7
Bug 1219322 - Document payload.info.flashVersion and payload.info.addons. r=gfritzsche

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b836b8feea9e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b836b8feea9e

Comment 7

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion