1191520 - Hide search settings footer until it is complete

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Dave Townsend [:mossop]]

Until we have the one-off searches in bug 1180944 it doesn't make a lot of sense to show the search settings footer.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b5168cc893e8

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b5168cc893e8

Comment 4

[Dave Townsend [:mossop]]

Per bug 1194898 this is still showing up in aurora builds

Comment 5

[Dave Townsend [:mossop]]

[Tracking Requested - why for this release]:
This feature should not be on on aurora.

Comment 6

[Dave Townsend [:mossop]]

Attachment: fix build config

Ok my previous patch was bad, didn't need the moz.build change.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4f5fec455502

Comment 8

[Dave Townsend [:mossop]]

Landed yesterday but didn't get updates for some reason: https://hg.mozilla.org/mozilla-central/rev/4f5fec455502

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4f5fec455502

Comment 10

[Dave Townsend [:mossop]]

Comment on attachment 8650210 [details] [diff] [review]
fix build config

Approval Request Comment
[Feature/regressing bug #]: Search suggestions
[User impact if declined]: This button shouldn't be visible without the additional work on the footer that is coming
[Describe test coverage new/current, TreeHerder]: In today's nightly
[Risks and why]: Low risk, just hides some UI
[String/UUID change made/needed]: None

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8650210 [details] [diff] [review]
fix build config

Polish patch, taking it.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9603c34d3237

Comment 13

[Petruta Horea [:phorea]]

Environments used: Ubuntu 14.04 x86, Win 10 x64, Mac OS X 10.9.5.

Verified using Dev Edition 42.0a2 2015-08-25 that the awesome bar footer with "Change Search Settings" button is no longer shown.

However, this is still visible in Nightly 43.0a1 2015-08-25. Is it expected?

Comment 14

[Marco Bonardo [:mak]]

yes, the footer should be only visible in Nightly (I'm honestly not sure it's a great idea but, we ended up there)