Closed
Bug 1151915
Opened 11 years ago
Closed 11 years ago
Make "saved-session" documentation more explicit
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
Attachments
(1 file, 1 obsolete file)
3.23 KB,
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
Minor documentation improvement.
Attachment #8589168 -
Flags: review?(vdjeric)
Comment 1•11 years ago
|
||
Comment on attachment 8589168 [details] [diff] [review]
Improve saved-session documentation
Review of attachment 8589168 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/telemetry/tests/unit/test_PingAPI.js
@@ +18,5 @@
> // and will be removed with bug 1149754.
> yield TelemetryPing.setup();
>
> const PING_TYPE = "test-ping-api";
> + let pings = new Map();
What's the motivation for this change?
@@ +25,2 @@
> let id = yield TelemetryPing.send(PING_TYPE, {});
> +
trailing space
Attachment #8589168 -
Flags: review?(vdjeric) → review+
![]() |
Assignee | |
Comment 2•11 years ago
|
||
(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #1)
> Comment on attachment 8589168 [details] [diff] [review]
> Improve saved-session documentation
>
> Review of attachment 8589168 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: toolkit/components/telemetry/tests/unit/test_PingAPI.js
> @@ +18,5 @@
> > // and will be removed with bug 1149754.
> > yield TelemetryPing.setup();
> >
> > const PING_TYPE = "test-ping-api";
> > + let pings = new Map();
>
> What's the motivation for this change?
Sorry about that - the test changes are completely unrelated and from a bad patch refresh.
Removing them before landing.
![]() |
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8589168 -
Attachment is obsolete: true
Attachment #8589577 -
Flags: review+
![]() |
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
![]() |
Assignee | |
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•