1121007 - FHR data migration: intl.accept_languages

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Alessio Placitelli [:Dexter]]

org.mozilla.appInfo.appinfo has the following data:
  isBlocklistEnabled (v2) - is NOT in telemetry
  isTelemetryEnabled (v2) - Is NOT in telemetry, but I don't think it is needed
  vendor - is NOT in telemetry
  name - is in telemetry via [1]
  id - is in telemetry via [1]
  version - is in telemetry via [1]
  appBuildID - is in telemetry via [1]
  platformVersion - is NOT in telemetry
  platformBuildID - is in telemetry via [1]
  os - is in telemetry via [1]
  xpcomabi - is NOT in telemetry
  updateChannel - is in telemetry via [1]
  distributionId - is NOT in telemetry
  distributionVersion - is NOT in telemetry
  hotfixVersion - is NOT in telemetry
  locale - is in telemetry via [1]
  isDefaultBrowser - via [2], BROWSER_IS_USER_DEFAULT histogram

We need to add isBlocklistEnabled, vendor, platformVersion, xpcomabi, distributionId, distributionVersion, hotfixVersion.

[1] - https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetryPing.jsm#523
[2] - https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json#6378

Comment 1

[Alessio Placitelli [:Dexter]]

All the fields mentioned in the previous comments are already in Telemetry's Environmnent. The newly added "acceptLangIsUserSet" [1] is not, so we should probably port that to Telemetry. This could be easily done by checking whether the user set an intl.accept_languages preference.

[1] - https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/services/healthreport/healthreport/dataformat.html

Comment 2

[Georg Fritzsche [:gfritzsche]]

(In reply to Alessio Placitelli [:Dexter] from comment #1)
> All the fields mentioned in the previous comments are already in Telemetry's
> Environmnent. The newly added "acceptLangIsUserSet" [1] is not, so we should
> probably port that to Telemetry. This could be easily done by checking
> whether the user set an intl.accept_languages preference.
> 
> [1] -
> https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/services/
> healthreport/healthreport/dataformat.html

Benjamin, is that potentially suitable for environment.settings.userPrefs?

Comment 3

[Benjamin Smedberg]

Since acceptlang is fennec-only, I believe there's nothing else that needs to happen here.