1120992 - Add totalTime (uptime in seconds) to the Telemetry session payload

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Georg Fritzsche [:gfritzsche]]

appSessions.current has the following data:
  startDay - is in Telemetry via nsIAppStartup.getStartupInfo().main timestamp
  activeTicks - is in Telemetry
  totalTime - integer seconds; we only have uptime so far, which is in minutes
  main - in Telemetry via nsIAppStartup.getStartupInfo()
  firstPaint - in Telemetry via nsIAppStartup.getStartupInfo()
  sessionRestored - in Telemetry via nsIAppStartup.getStartupInfo()

So, we only need to add totalTime to Telemetry for this.

Comment 1

[Georg Fritzsche [:gfritzsche]]

We can just add totalTime to the session payload here:
https://hg.mozilla.org/mozilla-central/annotate/df3daecd381f/toolkit/components/telemetry/TelemetrySession.jsm#l579
... from sr.totalTime.

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1120992.patch

This patch adds the |totalTime| to the Telemetry Session payload.

Adds test coverage to |test_TelemetrySession.js|.

Comment 3

[Vladan Djeric (:vladan)]

Comment on attachment 8571910 [details] [diff] [review]
bug1120992.patch

Review of attachment 8571910 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +577,5 @@
>  
>        let sr = drs.getSessionRecorder();
>        if (sr) {
>          ret.activeTicks = sr.activeTicks;
> +        ret.totalTime = sr.totalTime;

You don't need to rely on the datareporting service for this, you can just do  Math.round((new Date() - si.process) / 1000) like we already do for minutes uptime

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: bug1120992.patch - v2

Thank you for your time reviewing this, :vladan.

This patch computes totalTime as you suggested.

Comment 5

[Vladan Djeric (:vladan)]

Comment on attachment 8572531 [details] [diff] [review]
bug1120992.patch - v2

Review of attachment 8572531 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +495,3 @@
>      var ret = {
> +      totalTime: Math.round(elapsedTime / 1000), // totalTime, in seconds
> +      uptime: Math.round(elapsedTime / 60000) // uptime in minutes

heh these two measurements look kinda silly side-by-side, but let's keep both for now

Comment 6

[Alessio Placitelli [:Dexter]]

Yeah, they do :-/

That's the try push for this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efd9414f438e

Comment 7

[Alessio Placitelli [:Dexter]]

The JP oranges also happen on similar jobs and do not seem to be related.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/7b809001b656

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b809001b656