1111707 - Telemetry clientID always "null" on Fennec

Status: RESOLVED WORKSFORME

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

Whenever I check the about:telemetry page in release Fennec 34 on my HTC One M8, I see that the clientID field is null, regardless of the browser uptime

Comment 1

[Benjamin Smedberg]

This is to be expected because FHR on Android is done in Java not gecko.

Comment 2

[Georg Fritzsche [:gfritzsche]]

I dont think clientID is important for Fennec telemetry right now (from what i know FHR is still the major focus on mobile anyway).
We can revisit this if the mobile team requires it (or when we do the unification on mobile too).

Comment 3

[Georg Fritzsche [:gfritzsche]]

rvitillo found that we are submitting client ids on Fennec now (probably as a result of making the client id implementation independent of the desktop FHR code).

mfinkle and i don't see any code in mobile FHR that adds a client id - it looks like Fennec FHR never submitted a client id?

Comment 4

[Richard Newman [:rnewman]]

The v3 FHR document format has no clientID (neither did v2 at the time, IIRC), so Fennec's FHR doesn't include one.

Comment 5

[Benjamin Smedberg]

That is bug 981698.

Comment 6

[Benjamin Smedberg]

Georg, I'm confused about the resolution of this. Presumably we will need a clientID on Android, and bug 981698 is about FHRv3 which is going away.

Comment 7

[Georg Fritzsche [:gfritzsche]]

This is already working since we moved the client id implementation out of the desktop FHR code (bug 1137353 et al).