1106936 - [e10s] Loading Spinner Doesn't Activate

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20141202213802

Steps to reproduce:

The loading spinner doesn't activate (that's the one that spins to the right), only the connecting spinner activates. 


Actual results:

The problem is that this gives the perception of much slower load time than what actually happens. The user is made to feel like the machine is struggling to connect.


Expected results:

The loading/rendering spinner should appear as per non-e10s.

Comment 1

[Alice0775 White]

I can seethe problem on latest Nightly e10s windows7.

Comment 2

[Alice0775 White]

Regression window(fx)
Good:
https://hg.mozilla.org/integration/fx-team/rev/7553b7c1f35f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141117141551
Bad:
https://hg.mozilla.org/integration/fx-team/rev/ad799d59abdc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141117143554
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=7553b7c1f35f&tochange=ad799d59abdc

Regressed by;
ad799d59abdc	Tim Taubert — Bug 1099490 - [e10s] Use nsBrowserStatusFilter in the content to avoid a flood of progress messages being sent to the parent r=billm

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

I initially thought this was caused by the double-filtering in e10s but it actually is caused by the RemoteWebProgress not sending onProgressChange() notifications.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1106936-e10s-Fix-progress-throbber-for-remote-br.patch

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/84c03250d7f6

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Backed out for m1-e10s failures:

https://hg.mozilla.org/integration/fx-team/rev/faee1a0dc304

TEST-UNEXPECTED-FAIL | /tests/docshell/test/test_bug475636.html | Test timed out. - expected PASS

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

onRefreshAttempted() should of course default to allowing the action as long as we haven't implemented it yet.

https://tbpl.mozilla.org/?tree=Try&rev=5f974f323d14

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/cc368429c22a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc368429c22a

Comment 10

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 37.0a1 (2014-12-02) using Windows 7 x64.

Verified fixed on Latest Firefox 37.0a1 (2014-12-10) using Windows 7 x64, Ubuntu 12.04 x86 and Mac OSX 10.9.5.