1071868 - Need a profiler for CPOW activity

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We'd like to have some way to track how much CPOWs are costing us. The normal profiler should be able to help with this, but it would be nice to have something specific to CPOWs that would tell you the add-on sending the CPOW request and a callstack.

Comment 1

[Luke Wagner [:luke]]

Maybe this is what you were already thinking, but it seems like you could push a frame on the pseudo-stack (with FRAME_LABEL_COPY set if you are dynamically allocating/releasing the label).  Probably you can just hack in a new SPSProfiler method analogous to SPSProfiler::enterAsmJS.

The other thing you could do to help highlight CPOW time is add a new ProfilerEntry::Category label for CPOWs.  With that (and maybe some other hacks, I don't know how it works), in theory you'd get your own color on the new bar graph in the profiler.

Comment 2

[Benoit Girard (:BenWa)]

Yes, these days we can get all types of data into the profiler. Maybe you can elaborate on your ideal end results?

Comment 3

[Benoit Girard (:BenWa)]

If you want to build something into the sps profiler then it would mean this would block on bug 1008435.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I'd like to be able to see CPOW activity separated from everything else. If I can label CPOW stuff specially and exclude everything else in SPS, that would be great.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

we've got enough reporting around CPOWs in since this was filed