Closed
Bug 1054153
Opened 11 years ago
Closed 11 years ago
Block reading buffered ranges until MP4 dexmuxer has initialised
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: ajones, Assigned: ajones)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
6.40 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
Fix the race condition where we try to calculate the buffered ranges off the main thread before we've finished initialising the demuxer.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8474288 -
Flags: review?(edwin)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Comment on attachment 8474288 [details] [diff] [review]
Fix MP4 demuxer is init vs buffered range race
Review of attachment 8474288 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/media/fmp4/MP4Reader.cpp
@@ +815,2 @@
> resource->Pin();
> + nsresult res = resource->GetCachedRanges(ranges);
Super minor point: |nsresult| is usually named |rv|.
Attachment #8474288 -
Flags: review?(edwin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•